fix: Use instance origin for waiting forms and webhooks CORS headers instead of wildcard#2082
Open
fix: Use instance origin for waiting forms and webhooks CORS headers instead of wildcard#2082
Conversation
…-community-issue-form-trigger-always-loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of n8n-io/n8n#26133
Original author: michael-radency
Summary
Waiting webhooks(and forms) could break for users behind reverse proxies that strip
Access-Control-Allow-Origin: *responsesFix:
applyCorsnow uses the configured instance origin instead of * when the request has no real origin (CSP-sandboxed form pages). The origin is derived fromWEBHOOK_URL(falls back toN8N_HOST/N8N_PROTOCOL/N8N_PORT).Required:
WEBHOOK_URLmust be set to the public-facing n8n URL for the fix to take effectRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-4138/community-issue-form-trigger-always-loop
fixes n8n-io/n8n#23262
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)